MRG: Make use of AssociatedEmptyRoom field in *_meg.json #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
commented
May 6, 2021
hoechenberger
commented
May 6, 2021
agramfort
reviewed
May 6, 2021
hoechenberger
commented
May 6, 2021
hoechenberger
commented
May 6, 2021
hoechenberger
commented
May 6, 2021
hoechenberger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 94.25% 94.14% -0.11%
==========================================
Files 23 23
Lines 2974 3004 +30
==========================================
+ Hits 2803 2828 +25
- Misses 171 176 +5
Continue to review full report at Codecov.
|
agramfort
approved these changes
May 7, 2021
|
thx @hoechenberger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493.
write_raw_bidsgains a new parameter,empty_room, which allows users to specify an empty-room recording that belongs to the experimental MEG data. This information is stored in theAssociatedEmptyRoomfield in the*_meg.jsonsidecar file.BIDSPathgained anempty_roomproperty that parses the sidecar and returns aBIDSPathto the empty-room recording. If noAssociatedEmptyRoomkey is found in the sidecar, an error message is emitted, suggesting users may wish to useBIDSPath.find_empty_room()instead, which will try to find the "best-matching" empty-room recording based on session date.Would like to hear your thought on the API.
cc @agramfort @sappelhof
x-ref bids-standard/bids-specification#790 -> the BIDS specs are unclear, and I'm now just going ahead here with an implementation, also with the idea to provide something that "works in real-life" before trying to push the BIDS discussion forward again.
Merge checklist
Maintainer, please confirm the following before merging: